Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix genesis and support abstain #545

Merged
merged 6 commits into from
Jun 2, 2022
Merged

fix: fix genesis and support abstain #545

merged 6 commits into from
Jun 2, 2022

Conversation

0Tech
Copy link
Collaborator

@0Tech 0Tech commented May 26, 2022 •
edited
Loading

Description

This patch fixes bugs on x/foundation:

  1. fix unpacking of the foundation info.
  2. support abstain option (where the policy is percentage type).

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly. [no need]
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml [no need]

@0Tech 0Tech added the A: bug Something isn't working label May 26, 2022
@0Tech 0Tech self-assigned this May 26, 2022
@0Tech 0Tech marked this pull request as ready for review May 26, 2022 08:20
@0Tech 0Tech requested review from dudong2 and zemyblue May 26, 2022 08:21
@codecov
Copy link

codecov bot commented May 26, 2022 •
edited
Loading

Codecov Report

Merging #545 (97bcd3d) into main (1f94632) will increase coverage by 0.23%.
The diff coverage is 72.02%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #545      +/-   ##
==========================================
+ Coverage   57.34%   57.58%   +0.23%     
==========================================
  Files         791      793       +2     
  Lines       86263    86584     +321     
==========================================
+ Hits        49469    49858     +389     
+ Misses      33644    33564      -80     
- Partials     3150     3162      +12
Impacted Files Coverage Δ
x/foundation/client/testutil/grpc.go 92.10% <ø> (-2.59%) ⬇️
x/foundation/codec.go 0.00% <0.00%> (ø)
x/foundation/keeper/grpc_query.go 4.34% <0.00%> (-14.01%) ⬇️
x/foundation/keeper/genesis.go 77.92% <52.54%> (+2.48%) ⬆️
x/foundation/genesis.go 76.19% <52.83%> (-3.18%) ⬇️
x/foundation/keeper/proposal.go 69.14% <60.00%> (-0.30%) ⬇️
x/foundation/keeper/grant.go 63.82% <63.82%> (ø)
x/foundation/foundation.go 80.50% <69.69%> (+42.10%) ⬆️
x/foundation/msgs.go 85.02% <77.35%> (+16.96%) ⬆️
x/foundation/keeper/keeper.go 83.33% <77.77%> (-8.67%) ⬇️
... and 21 more

dudong2
dudong2 approved these changes May 27, 2022
View reviewed changes
Copy link
Contributor

@dudong2 dudong2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zemyblue
zemyblue approved these changes May 31, 2022
View reviewed changes
Copy link
Member

@zemyblue zemyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0Tech 0Tech merged commit ac918ac into Finschia:main Jun 2, 2022
@0Tech 0Tech deleted the foundation branch June 2, 2022 01:37
@zemyblue zemyblue mentioned this pull request Oct 27, 2022
Merged
5 tasks
@zemyblue zemyblue mentioned this pull request Nov 28, 2022
Merged
5 tasks
@0Tech 0Tech added the C:x/foundation x/foundation module label Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dudong2 dudong2 dudong2 approved these changes

@zemyblue zemyblue zemyblue approved these changes

Assignees

@0Tech 0Tech

Labels
A: bug Something isn't working C:x/foundation x/foundation module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0Tech @zemyblue @dudong2